Skip to content

Commit 8dd1326

Browse files
authored
Fix regression report-size-deltas after updating upload-artifact. (#15)
For more information see https://github.com/arduino/report-size-deltas/blob/main/docs/FAQ.md#size-deltas-report-workflow-triggered-by-schedule-event .
1 parent 0d0f2de commit 8dd1326

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

.github/workflows/compile-examples.yml

+7-6
Original file line numberDiff line numberDiff line change
@@ -34,27 +34,27 @@ jobs:
3434
platforms: |
3535
- name: rp2040:rp2040
3636
source-url: https://github.com/earlephilhower/arduino-pico/releases/download/global/package_rp2040_index.json
37+
artifact-name-suffix: rp2040-rp2040-arduino_nano_connect
3738
- fqbn: rp2040:rp2040:rpipico
3839
platforms: |
3940
- name: rp2040:rp2040
4041
source-url: https://github.com/earlephilhower/arduino-pico/releases/download/global/package_rp2040_index.json
42+
artifact-name-suffix: rp2040-rp2040-rpipico
4143
- fqbn: arduino:renesas_portenta:portenta_c33
4244
platforms: |
4345
- name: arduino:renesas_portenta
46+
artifact-name-suffix: renesas-portenta-portenta-c33
4447
- fqbn: arduino:renesas_uno:minima
4548
platforms: |
4649
- name: arduino:renesas_uno
50+
artifact-name-suffix: renesas-uno-minima
4751

4852
steps:
4953
- name: Checkout
5054
uses: actions/checkout@v4
5155

52-
- name: Install ESP32 platform dependencies
53-
if: startsWith(matrix.board.fqbn, 'esp32:esp32')
54-
run: pip3 install pyserial
55-
5656
- name: Compile examples
57-
uses: arduino/compile-sketches@main
57+
uses: arduino/compile-sketches@v1
5858
with:
5959
fqbn: ${{ matrix.board.fqbn }}
6060
platforms: ${{ matrix.board.platforms }}
@@ -67,5 +67,6 @@ jobs:
6767
if: github.event_name == 'pull_request'
6868
uses: actions/upload-artifact@v4
6969
with:
70-
name: ${{ env.SKETCHES_REPORTS_PATH }}
70+
if-no-files-found: error
7171
path: ${{ env.SKETCHES_REPORTS_PATH }}
72+
name: sketches-report-${{ matrix.board.artifact-name-suffix }}

.github/workflows/report-size-deltas.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,7 @@ jobs:
1111
steps:
1212
# See: https://github.com/arduino/report-size-deltas/README.md
1313
- name: Comment size deltas reports to PRs
14-
uses: arduino/report-size-deltas@main
14+
uses: arduino/report-size-deltas@v1
15+
with:
16+
# Regex matching the names of the workflow artifacts created by the "Compile Examples" workflow
17+
sketches-reports-source: ^sketches-report-.+

0 commit comments

Comments
 (0)