Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove balance check before executing route #347

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

odcey
Copy link
Contributor

@odcey odcey commented Dec 3, 2024

Goal: Remove balance check before route execution - avoid RPC rate limiting

The wallet is already doing a balance check

  • add new param to route execution: bypassBalanceChecks

Copy link
Contributor

@jmdev3 jmdev3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@odcey odcey merged commit 9334ea0 into main-v2 Dec 3, 2024
4 of 5 checks passed
@odcey odcey deleted the chore/remove-balance-check branch December 3, 2024 14:03
rajat43 pushed a commit that referenced this pull request Feb 20, 2025
* chore: remove balance check before executing route

* Revert "chore: remove balance check before executing route"

This reverts commit 39cf7bb.

* chore: introduce bypassBalanceChecks var for route execution

* chore: remove unused param
rajat43 pushed a commit that referenced this pull request Feb 24, 2025
* chore: remove balance check before executing route

* Revert "chore: remove balance check before executing route"

This reverts commit 39cf7bb.

* chore: introduce bypassBalanceChecks var for route execution

* chore: remove unused param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants