Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana signing #344

Merged
merged 9 commits into from
Dec 23, 2024
Merged

solana signing #344

merged 9 commits into from
Dec 23, 2024

Conversation

nnoln
Copy link
Contributor

@nnoln nnoln commented Nov 15, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • closes 0xsquid/squid-core# (issue number)
  • Zenhub issue: (optional)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (code improvement)
  • Styles (adding, editing or fixing styles)
  • Unit test

How Has This Been Tested?

Please describe the steps to test.

Evidence

Please add some evidence like screenshots or records.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nnoln nnoln requested a review from a team November 15, 2024 22:15
lint-action and others added 6 commits November 15, 2024 22:15
"long": "^5.2.3",
"@solana/web3.js": "1.95.3",
"@project-serum/anchor": "^0.26.0",
"bs58": "^6.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see a direct usage of bs58 in this pull request
is it something mandatory to have installed manually to be paired with web3js or anchor ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had it installed locally, cuz it needed for some solana tx encoding/decoding
Haven't tried sending a tx without this package

@jmdev3 jmdev3 merged commit 994dd8a into main-v2 Dec 23, 2024
5 checks passed
@jmdev3 jmdev3 deleted the feat/solana-signing branch December 23, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants