Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/get token price #332

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix/get token price #332

merged 2 commits into from
Aug 27, 2024

Conversation

odcey
Copy link
Contributor

@odcey odcey commented Aug 27, 2024

Description

  • Tests were failing to get token price (accessing data.token instead of data.tokens)
  • Add numbers.ts utils
  • Add relevant test for new method isValidNumber
  • Update test methodology, now handling all .spec.ts files

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (code improvement)
  • Styles (adding, editing or fixing styles)
  • Unit test

How Has This Been Tested?

numbers.spec.ts

Evidence

Before
image
After
Screen Shot 2024-08-27 at 11 51 49

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@odcey odcey requested review from jmdev3 and genaroibc August 27, 2024 09:55
@odcey odcey merged commit feabab9 into main-v2 Aug 27, 2024
5 checks passed
@odcey odcey deleted the fix/get-token-price branch August 27, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants