Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/cosmos exec condition #301

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Chore/cosmos exec condition #301

merged 5 commits into from
Apr 8, 2024

Conversation

genaroibc
Copy link
Contributor

@genaroibc genaroibc commented Apr 6, 2024

Description

Add optional param useBroadcast to executeRoute() and executeRouteCosmos() methods.
When useBroadcast: true, executeRouteCosmos() uses signer.signAndBroadcast() instead of signer.sign() to sign transactions.

The purpose of this is that we are integrating Nomos, a multisig provider, and they reserve sign() for apps to verify user signatures, but instead override signAndBroadcast() to include their custom logic.

This PR also changes how we determine whether to use executeRouteEvm() or executeRouteCosmos().
Now it parses fromChain from route params. If fromChain is a number, use executeRouteEvm(). If not, use executeRouteCosmos().

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactor (code improvement)

How Has This Been Tested?

Please describe the steps to test.

Evidence

Please add some evidence like screenshots or records.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

odcey and others added 4 commits March 27, 2024 22:21
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: pilot <8565879+odcey@users.noreply.github.com>
@odcey odcey requested a review from jmdev3 April 8, 2024 08:39
src/index.ts Outdated Show resolved Hide resolved
@odcey odcey self-requested a review April 8, 2024 14:46
@odcey odcey merged commit 400445d into main Apr 8, 2024
5 checks passed
@odcey odcey deleted the chore/cosmos-exec-condition branch April 8, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants