Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove validate_param method #1646

Open
plafer opened this issue Jan 28, 2025 · 0 comments
Open

Remove validate_param method #1646

plafer opened this issue Jan 28, 2025 · 0 comments
Labels
assembly Related to Miden assembly enhancement New feature or request good first issue Good for newcomers

Comments

@plafer
Copy link
Contributor

plafer commented Jan 28, 2025

The validate_param method doesn't produce a nice error message since it doesn't include a span & source. Therefore, the user is left with a parameter value must be greater than or equal to {min} and less than or equal to {max}, but was {value} error message, without knowing what parameter the error refers to.

We should change all methods that use validate_param() in a manner similar to how #1640 did it.
@plafer plafer added assembly Related to Miden assembly enhancement New feature or request good first issue Good for newcomers labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assembly Related to Miden assembly enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plafer