Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(faucet): missing background and favicon routes #672

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

Mirko-von-Leipzig
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig commented Feb 7, 2025

Closes #671.

Created #673 to create tests for this.


I've deployed this to devnet and confirmed that

  • both background and favicon load as expected, and
  • no console errors

Did require clearing my cache first.

@Mirko-von-Leipzig Mirko-von-Leipzig marked this pull request as ready for review February 7, 2025 05:52
@Mirko-von-Leipzig Mirko-von-Leipzig marked this pull request as draft February 7, 2025 06:15
@Mirko-von-Leipzig Mirko-von-Leipzig marked this pull request as ready for review February 7, 2025 06:41
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! Question: should this go into main?

@Mirko-von-Leipzig
Copy link
Contributor Author

Looks good! Thank you! Question: should this go into main?

If we care to make a new release with it, then main probably.

@bobbinth
Copy link
Contributor

bobbinth commented Feb 8, 2025

If we care to make a new release with it, then main probably.

Maybe we release just the faucet crate? And for a change like this, we may even skip tagging a release.

@Mirko-von-Leipzig
Copy link
Contributor Author

If we care to make a new release with it, then main probably.

Maybe we release just the faucet crate? And for a change like this, we may even skip tagging a release.

I'll rebase to main.

Its a bit awkward with the formal deployment, options:

  1. We use Deploy from the main branch - no release required. But this will currently redeploy everything. Would have to add an option to only deploy the faucet.
  2. We manually deploy...
    1. using the faucet debian package - but this requires a github release to build it
    2. by manually building on the instance

(2ii) is the easiest and probably also the safest - but not popular with devops of course :D

@bobbinth
Copy link
Contributor

bobbinth commented Feb 8, 2025

eh - seems like all of these are a bit of a hassle for just adding a background image. let's just keep things as they are now.

@bobbinth bobbinth merged commit 03622e7 into next Feb 8, 2025
12 checks passed
@bobbinth bobbinth deleted the mirko/faucet-routes branch February 8, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants