feat: taking iterator in select_block_headers #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun-doshi
force-pushed
the
varun/block-iterator
branch
from
4f00459 to
7eb54f4
Compare
bobbinth
reviewed
Feb 5, 2025
varun-doshi
force-pushed
the
varun/block-iterator
branch
from
7eb54f4 to
068e82d
Compare
PhilippGackstatter
approved these changes
Feb 5, 2025
varun-doshi
force-pushed
the
varun/block-iterator
branch
from
068e82d to
6a17bff
Compare
|
Added Changelog and corrected the formatting |
|
@varun-doshi Can you fix the merge conflict with the changelog? Thanks! @Mirko-von-Leipzig Should we merge this afterwards? |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #664
Replaces taking a
Vecinselect_block_headerswith taking animpl Iterator