Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faucet webpage rejects valid account IDs #655

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix: faucet webpage rejects valid account IDs #655

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf3a859
Fix faucet webpage rejecting valid account IDs
Mirko-von-Leipzig Jan 29, 2025
45fef4f
bump version to v0.7.2
Mirko-von-Leipzig Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,16 @@

## Unreleased

### Fixes

- Faucet webpage rejects valid account IDs (#655).

## v0.7.1 (2025-01-28)

### Fixes

- Faucet webpage fails to load styling (index.css) and script (index.js) (#647).

### Changes

- [BREAKING] Default faucet endpoint is now public instead of localhost (#647).
Expand Down
2 changes: 1 addition & 1 deletion bin/faucet/src/static/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ document.addEventListener('DOMContentLoaded', function () {
let accountId = accountIdInput.value.trim();
errorMessage.style.display = 'none';

if (!accountId || !/^0x[0-9a-fA-F]{16}$/i.test(accountId)) {
if (!accountId || !/^0x[0-9a-fA-F]{30}$/i.test(accountId)) {
errorMessage.textContent = !accountId ? "Account ID is required." : "Invalid Account ID.";
errorMessage.style.display = 'block';
return;
Expand Down
Loading