Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faucet webpage rejects valid account IDs #655

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

Mirko-von-Leipzig
Copy link
Contributor

@Mirko-von-Leipzig Mirko-von-Leipzig commented Jan 29, 2025

We forgot to update the faucet's script file when upgrading account ID from 1 to 2 felts.

I've also added in a changelog entry for the previous version's bugfix.

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left one comment inline.

@Mirko-von-Leipzig Mirko-von-Leipzig marked this pull request as ready for review January 29, 2025 10:49
@Mirko-von-Leipzig Mirko-von-Leipzig merged commit 244eba1 into main Jan 29, 2025
9 checks passed
@Mirko-von-Leipzig Mirko-von-Leipzig deleted the mirko/fix/faucet-rejects-accounts branch January 29, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants