[Feature]: Improve implementation of get_state_sync removing details

[phklive]

To whom is this feature for?

End user

Why is is this feature needed?

To reduce the amount of computation made by get_state_sync

miden-node/store/src/db/sql.rs

Line 629 in 3c8ba12

pub fn get_state_sync(

How is this feature used?

As of now the sql queries done on the store database for get_state_sync requires us to make another query with is select_notes_since_block_by_tag_and_sender to get notes.

We want to remove details from this query to be able to not have to make a high amount of work. If needed the user will make a subsequent query to get_notes_by_id to query on-chain note details.

Anything else?

#300 (comment)

[Dominik1999]

Would a user be able to get a note by its ID? The issue is not super clear to me

[bobbinth]

The user should already be able to do that. This issue is of an optimization issue for how things are handled internally (currently, we do more work than needed in some situations).

[polydez]

Resolved by #462