feat: merge account updates details #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Jul 17, 2024
bobbinth
reviewed
Jul 17, 2024
bobbinth
reviewed
Jul 18, 2024
bobbinth
reviewed
Jul 22, 2024
Mirko-von-Leipzig
force-pushed
the
merge-account-updates
branch
from
621026b to
54fbfbc
Compare
|
I believe I've addressed all review comments. I've added tests - though note that I used |
This enables creating mappings for related types. Some types required manual impls as Felt does not implement Hash. This feels like an oversight.
The latter is not nostd compliant.
Address review comments
Mirko-von-Leipzig
force-pushed
the
merge-account-updates
branch
from
dbd4a58 to
64cb18c
Compare
bobbinth
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
AccountUpdateDetails::mergewhich combines two update details. This is required by the node to support merging multiple transactions on the same account.I implemented the merging using hashmaps to ensure only the final update is applied. This requiredUseHashon several structs, and unfortunatelyFeltdoes not implementHashitself so this required manually implementing it in some cases.BTreeMapinstead which doesn't requireHashand isnostdcompliant.The structs themselves actually look like they should contain hashmaps instead of vectors as this would be more type safe imo. However, since they aren't this makes me question my approach. I'll ask more specific questions inline so that the conversation is easier to track.
I also have sometodo!()which I don't know how to implement.As a side-note we could also use something like
Slottype, similar toNonZeroU8but which disallows the "illegal" slots.