Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: clear the stack on set_map_item #785

Merged
merged 1 commit into from
Jul 3, 2024
Merged

bugfix: clear the stack on set_map_item #785

merged 1 commit into from
Jul 3, 2024

Conversation

hackaugusto
Copy link
Contributor

@hackaugusto hackaugusto requested a review from bobbinth July 3, 2024 14:06
@hackaugusto hackaugusto mentioned this pull request Jul 3, 2024
Closed
bobbinth
bobbinth approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! Let's make the CI green and then merge.

@hackaugusto hackaugusto force-pushed the hacka-set_map_item-stack-cleanup branch from 8ec7758 to aee3dd9 Compare July 3, 2024 15:56
@hackaugusto
Copy link
Contributor Author

Looks good! Thank you! Let's make the CI green and then merge.

Ah, I forgot to update the MAST roots. Should be green now.

@hackaugusto hackaugusto merged commit a279bd8 into next Jul 3, 2024
12 checks passed
@hackaugusto hackaugusto deleted the hacka-set_map_item-stack-cleanup branch July 3, 2024 16:12
bobbinth pushed a commit that referenced this pull request Jul 4, 2024
@hackaugusto @bobbinth
bugfix: clear the stack on set_map_item (#785)
7220401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackaugusto @bobbinth