kernel: add support for delayed note inclusion checks #759
Conversation
hackaugusto
force-pushed
the
hacka-kernel-delayed-note-inclusion
branch
3 times, most recently
from
0362fd8 to
7d6f603
Compare
There was a problem hiding this comment.
Looks good! Thank you! I left some comments inline. Most of them are pretty minor. The main one is about the potential flaw in how input note commitment does not commit to metadata of notes with delayed inclusion proofs. I think we can tackle this problem in the next PR (and I'll write up some thoughts about how to do it in the issue itself).
So, let's address the smaller comments and merge.
| #! Note: The note's metadata is validated when the note is authenticated, since | ||
| #! the authentication is `hash(NOTE_ID || NOTE_METADATA)`. This is either done | ||
| #! by the procedure `authenticate_note` for or delayed to another kernel. |
There was a problem hiding this comment.
One thing I just realized: input notes commitment does not commit to the metadata of notes with delayed inclusion proofs. I haven't thought this through entirely - but this may be a problem as whoever executes the transaction could set the metadata for such notes to arbitrary values.
If it is a problem, we'll need to include note metadata into the input notes commitment as well somehow.
hackaugusto
force-pushed
the
hacka-kernel-delayed-note-inclusion
branch
from
7d6f603 to
37fb5f1
Compare
Implements the changes to the kernel's prologue, which are necessary to support delayed note inclusion. Along side some code and documentation improvements.
closes #353
Currently marked as a draft because this PR is lacking tests.