CI: Swap-out deprecated rust toolchain #545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
force-pushed
the
phklive-swap-deprecated-rust-toolchchain
branch
from
72a1f66 to
a50b6f1
Compare
|
This is also the crate used by Reth or other rust projects: https://github.com/paradigmxyz/reth/blob/cf163ba9d81c9e11ee3798b8474c1b4c679c24e2/.github/workflows/unit.yml#L33 |
|
@hackaugusto related to this pr on winterfell: facebook/winterfell#270 Could you let me know what is your POV on using this gh action or using the direct rustup installation? |
In general, including for code, I prefer fewer layers of indirection. I would go for the simpler shell scripts, unless the actions provides some benefit over that which is hard for us to implement. |
bobbinth
force-pushed
the
next
branch
2 times, most recently
from
af32706 to
7e2a164
Compare
|
Superseded by #696. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I remove the deprecated https://github.com/actions-rs and swap it with https://github.com/dtolnay/rust-toolchain