-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mock: add proven tx builder #474
Merged
+84
−5
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
use miden_objects::{ | ||
accounts::AccountId, | ||
notes::{NoteEnvelope, Nullifier}, | ||
transaction::{InputNotes, OutputNotes, ProvenTransaction, ToEnvelope, ToNullifier}, | ||
vm::ExecutionProof, | ||
Digest, | ||
}; | ||
use miden_prover::{HashFunction, StarkProof}; | ||
|
||
/// Builder for an `ProvenTransaction`, the builder allows for a fluent API to construct an account. | ||
/// Each transaction needs a unique builder. | ||
#[derive(Debug, Clone)] | ||
#[cfg_attr(feature = "serde", derive(serde::Deserialize, serde::Serialize))] | ||
pub struct ProvenTransactionBuilder { | ||
account_id: AccountId, | ||
note_envelopes: Vec<NoteEnvelope>, | ||
nullifiers: Vec<Nullifier>, | ||
initial_account_hash: Digest, | ||
final_account_hash: Digest, | ||
} | ||
|
||
impl ProvenTransactionBuilder { | ||
pub fn new( | ||
account_id: AccountId, | ||
initial_account_hash: Digest, | ||
final_account_hash: Digest, | ||
) -> Self { | ||
Self { | ||
account_id, | ||
initial_account_hash, | ||
final_account_hash, | ||
note_envelopes: Vec::new(), | ||
nullifiers: Vec::new(), | ||
} | ||
} | ||
|
||
pub fn add_note_envelope<I: ToEnvelope>(mut self, note_envelope: I) -> Self { | ||
self.note_envelopes.push(note_envelope.to_envelope()); | ||
self | ||
} | ||
pub fn add_note_envelopes<I: IntoIterator<Item = NoteEnvelope>>( | ||
mut self, | ||
note_envelopes: I, | ||
) -> Self { | ||
for note_envelope in note_envelopes.into_iter() { | ||
self.note_envelopes.push(note_envelope.to_envelope()); | ||
} | ||
self | ||
} | ||
|
||
pub fn add_nullifier<I: ToNullifier>(mut self, nullifier: I) -> Self { | ||
self.nullifiers.push(nullifier.nullifier()); | ||
self | ||
} | ||
|
||
pub fn build(self) -> ProvenTransaction { | ||
ProvenTransaction::new( | ||
self.account_id, | ||
self.initial_account_hash, | ||
self.final_account_hash, | ||
InputNotes::new(self.nullifiers).unwrap(), | ||
OutputNotes::new(self.note_envelopes).unwrap(), | ||
None, | ||
Digest::default(), | ||
ExecutionProof::new(StarkProof::new_dummy(), HashFunction::Blake3_192), | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,6 +33,10 @@ pub trait ToEnvelope: | |
{ | ||
fn id(&self) -> NoteId; | ||
fn metadata(&self) -> NoteMetadata; | ||
|
||
fn to_envelope(&self) -> NoteEnvelope { | ||
NoteEnvelope::new(self.id(), self.metadata()) | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} | ||
|
||
impl ToEnvelope for OutputNote { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this meant to replace
MockProvenTxBuilder
inmiden-node
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is possible, I would think it is a good idea. The rationale is that having fewer utilities doing the same is best, and the utilities in
miden-base
can be used on the other projects, likemiden-client
.