Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set supported types correctly #1103

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix: Set supported types correctly #1103

merged 2 commits into from
Jan 24, 2025

Conversation

igamigo
Copy link
Collaborator

@igamigo igamigo commented Jan 24, 2025

Unfortunately I missed this before the latest release. It can be worked around by adding the type after instantiation but still needed to be done here.

@igamigo igamigo added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Jan 24, 2025
bobbinth
bobbinth approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! Once merged, I can release this as v0.7.1 - so, it should propagate seamlessly to the client.

@igamigo igamigo merged commit e8c8d30 into main Jan 24, 2025
12 checks passed
@igamigo igamigo deleted the igamigo-from-template branch January 24, 2025 17:23
@bobbinth bobbinth mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igamigo @bobbinth