Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce moving pre-defined account components' source code into masm files #1097

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

PhilippGackstatter
Copy link
Contributor

This PR reintroduces the changes from #960 parts of which have somehow gone missing on next.

This mainly compiles account components from the files introduced in #960 instead of defining the code in constants.

@PhilippGackstatter PhilippGackstatter added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Jan 23, 2025
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

For now, this doesn't have any practical implications, right? If it doesn't, I think we can merge it into next (otherwise, we should probably merge it into main).

@PhilippGackstatter
Copy link
Contributor Author

For now, this doesn't have any practical implications, right?

Yeah, agreed. This is basically a cosmetic and internal-only change, so next seems fine.

@bobbinth bobbinth merged commit 89f54bc into next Jan 23, 2025
12 of 13 checks passed
@bobbinth bobbinth deleted the pgackst-account-components-build-2 branch January 23, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This PR does not require an entry in the `CHANGELOG.md` file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants