Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove push.* drop's before decorator usage #979

Closed
Fumuran opened this issue Nov 24, 2024 · 2 comments
Closed

Remove push.* drop's before decorator usage #979

Fumuran opened this issue Nov 24, 2024 · 2 comments
Milestone
v0.7

Comments

@Fumuran
Copy link
Contributor

Fumuran commented Nov 24, 2024

What should be done?

Since 0xPolygonMiden/miden-vm#1122 has been merged, we should be able to remove additional push.* drop lines before decorators invocation.

How should it be done?

Lines marked as # TODO: remove line, see miden-vm/#1122 should be removed.

When is this task done?

This task is done when masm code will be correctly executed without additional push.* drop lines.

Additional context

No response
@Fumuran Fumuran changed the title Remove push dpop's before decorator usage Remove push.* drop's before decorator usage Nov 24, 2024
@Fumuran Fumuran mentioned this issue Nov 24, 2024
Merged
@bobbinth
Copy link
Contributor

@PhilippGackstatter - this is largely done already, right? Or is there more of this remaining?

@PhilippGackstatter
Copy link
Contributor

Yes, the last remaining one is removed in #1090, but most of them were removed in #1073, so closing this issue.

@bobbinth bobbinth added this to the v0.7 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.7
Development

No branches or pull requests
3 participants
@PhilippGackstatter @Fumuran @bobbinth