Rename OutputNote variants

[hackaugusto]

What should be done?

Rename Public to Full and Private to Minimal

How should it be done?

Straight forward renaming

When is this task done?

When the enum variants are renamed in the whole codebase

Additional context

#572 (comment)

[bobbinth]

This will actually be more than just renaming. After this the Full category will contain both public and private notes (and Minimal category will contain only private notes). So, we'll need to update the logic which sorts the notes into one group or the other. We will also need to convert all "full" private notes into "minimal" private notes when we built ProvenTransaction object from ExecutedTransaction.

[bobbinth]

This is actually related to #496 - once this is resolved #496 should be resolved too.

[bobbinth]

@polydez - after my refactoring in #645, I think the variant names could be:

pub enum OutputNote {
    Full(Note),
    Header(NoteHeader),
}

Also, in your PR, it might make sense to make the refactoring I mentioned in #614 (comment) as @Dominik1999 is out today and he probably won't get to this until tomorrow.

[polydez]

Closed as resolved by #673