Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all data of a note is available for public notes. #585

Open
hackaugusto opened this issue Apr 9, 2024 · 1 comment
Open

Ensure all data of a note is available for public notes. #585

hackaugusto opened this issue Apr 9, 2024 · 1 comment

Comments

@hackaugusto
Copy link
Contributor

hackaugusto commented Apr 9, 2024

What should be done?

Ensure every value of a note is fully available when its type is Public. This includes the complete MASM source code, forbidden phantom calls. The note inputs, and the serial_num.

How should it be done?

When is this task done?

When the protocol enforces the availability of the public note data, and verifies the data is valid.

Additional context

#572 (comment)

@bobbinth
Copy link
Contributor

bobbinth commented Apr 9, 2024

We should tackle this after we transition to using MAST as the serialized format for note/account code.

@hackaugusto hackaugusto changed the title Add verification for note script when decoding Ensure all data of a note is available for public notes. May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants