Skip to content

Commit

Permalink
after review
Browse files Browse the repository at this point in the history
  • Loading branch information
Dominik1999 committed Jun 14, 2024
1 parent 1ba6857 commit ed93d8f
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 6 deletions.
4 changes: 2 additions & 2 deletions miden-lib/asm/kernels/transaction/api.masm
Original file line number Diff line number Diff line change
Expand Up @@ -538,8 +538,8 @@ export.create_note
# prepare stack for return. Note: when create_note is called, the stack looks
# like [tag, aux, note_type, RECIPIENT, x, X, X], with 16 elements and X might be important data
# for the user. Without padding the kernel returns [note_idx, x, X, X, 0, 0, ZERO] adding 0's.
# To keep the data in position we move 0's to the left between ptr and the potentially important
# first element x.
# To keep the data in position we move 0's to the left between note_idx and the potentially
# important first element x.
movupw.3 movup.15 movup.15 movup.6
# => [note_idx, 0, 0, 0, 0, 0, 0]
end
Expand Down
2 changes: 1 addition & 1 deletion miden-lib/asm/miden/contracts/faucets/basic_fungible.masm
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export.basic::auth_tx_rpo_falcon512

#! Distributes freshly minted fungible assets to the provided recipient.
#! Inputs: [amount, tag, aux, note_type, RECIPIENT]
#! Outputs: [note_idx, 0, 0, 0, 0, 0, 0, 0, 0, ...]
#! Outputs: [note_idx, 0, 0, 0, 0, 0, 0, 0, ...]
#!
#! - amount is the amount to be minted and sent.
#! - tag is the tag to be included in the note.
Expand Down
2 changes: 1 addition & 1 deletion miden-lib/asm/miden/contracts/wallets/basic.masm
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ end
#! to the specified recipient.
#!
#! Inputs: [ASSET, tag, aux, note_type, RECIPIENT, ...]
#! Outputs: [note_idx, ZERO, ZERO, 0, ...]
#! Outputs: [note_idx, ZERO, ZERO, 0, 0, ...]
#!
#! - ASSET is the non-fungible asset of interest.
#! - tag is the tag to be included in the note.
Expand Down
2 changes: 1 addition & 1 deletion miden-lib/src/notes/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use miden_objects::{
Note, NoteAssets, NoteDetails, NoteExecutionHint, NoteInputs, NoteMetadata, NoteRecipient,
NoteTag, NoteType,
},
NoteError, Word, Felt,
Felt, NoteError, Word,
};

use self::utils::build_note_script;
Expand Down
14 changes: 13 additions & 1 deletion objects/src/testing/account_code.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,19 @@ use crate::accounts::AccountCode;

// The MAST root of the default account's interface. Use these constants to interact with the
// account's procedures.
const MASTS: [&str; 11] = ["0xbb58a032a1c1989079dcc73c279d69dcdf41dd7ee923d99dc3f86011663ec167", "0x549d264f00f1a6e90d47284e99eab6d0f93a3d41bb5324743607b6902978a809", "0x704ed1af80a3dae74cd4aabeb4c217924813c42334c2695a74e2702af80a4a35", "0xa27f4acf44ab50969468ea3fccbaae3893bd2117d2e0a60b7440df4ddb3a4585", "0x646ab6d0a53288f01083943116d01f216e77adfe21a495ae8d4670b4be40facf", "0x73c14f65d2bab6f52eafc4397e104b3ab22a470f6b5cbc86d4aa4d3978c8b7d4", "0x55036198d82d2af653935226c644427162f12e2a2c6b3baf007c9c6f47462872", "0xf484a84dad7f82e8eb1d5190b43243d02d9508437ff97522e14ebf9899758faa", "0xf17acfc7d1eff3ecadd7a17b6d91ff01af638aa9439d6c8603c55648328702ae", "0xff06b90f849c4b262cbfbea67042c4ea017ea0e9c558848a951d44b23370bec5", "0x8ef0092134469a1330e3c468f57c7f085ce611645d09cc7516c786fefc71d794"];
const MASTS: [&str; 11] = [
"0xbb58a032a1c1989079dcc73c279d69dcdf41dd7ee923d99dc3f86011663ec167",
"0x549d264f00f1a6e90d47284e99eab6d0f93a3d41bb5324743607b6902978a809",
"0x704ed1af80a3dae74cd4aabeb4c217924813c42334c2695a74e2702af80a4a35",
"0xa27f4acf44ab50969468ea3fccbaae3893bd2117d2e0a60b7440df4ddb3a4585",
"0x646ab6d0a53288f01083943116d01f216e77adfe21a495ae8d4670b4be40facf",
"0x73c14f65d2bab6f52eafc4397e104b3ab22a470f6b5cbc86d4aa4d3978c8b7d4",
"0x55036198d82d2af653935226c644427162f12e2a2c6b3baf007c9c6f47462872",
"0xf484a84dad7f82e8eb1d5190b43243d02d9508437ff97522e14ebf9899758faa",
"0xf17acfc7d1eff3ecadd7a17b6d91ff01af638aa9439d6c8603c55648328702ae",
"0xff06b90f849c4b262cbfbea67042c4ea017ea0e9c558848a951d44b23370bec5",
"0x8ef0092134469a1330e3c468f57c7f085ce611645d09cc7516c786fefc71d794",
];
pub const ACCOUNT_SEND_ASSET_MAST_ROOT: &str = MASTS[1];
pub const ACCOUNT_INCR_NONCE_MAST_ROOT: &str = MASTS[2];
pub const ACCOUNT_SET_ITEM_MAST_ROOT: &str = MASTS[3];
Expand Down

0 comments on commit ed93d8f

Please sign in to comment.