Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smt: remove inner nodes when removing value #269

Merged
merged 7 commits into from
Feb 4, 2024
Merged

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Feb 3, 2024

Closes: #246

Fixes the test breaking in 0xPolygonMiden/miden-base#449

@plafer plafer requested a review from bobbinth February 3, 2024 18:19
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I've added a couple of extra asserts in the Smt tests - just to make sure these conditions are explicitly tested for.

@bobbinth bobbinth linked an issue Feb 4, 2024 that may be closed by this pull request
@bobbinth bobbinth merged commit 73f702f into next Feb 4, 2024
9 checks passed
@bobbinth bobbinth deleted the plafer-fix-246 branch February 4, 2024 08:35
Copy link

sonarqubecloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smt: remove inner nodes when an empty value is inserted
2 participants