Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad bytes with 10*0 #267

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Pad bytes with 10*0 #267

merged 1 commit into from
Jan 27, 2024

Conversation

Al-Kindi-0
Copy link
Collaborator

Describe your changes

The intention with the RPX new padding rule was to always pad the bytes with 10*0 but for some reason this wasn't included in the original PR. This one fixes that.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@Al-Kindi-0 Al-Kindi-0 requested a review from bobbinth January 26, 2024 11:10
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you!

@bobbinth bobbinth merged commit 9ab18e2 into next Jan 27, 2024
10 checks passed
@bobbinth bobbinth deleted the al-fix-pad-bytes branch January 27, 2024 01:54
@Al-Kindi-0 Al-Kindi-0 self-assigned this Jan 30, 2024
bobbinth pushed a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants