-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
partialmmr: Method add with support for a single peak and tracking #263
Conversation
d1fd2ea
to
190705a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I left a few comments inline - most a very minor but I also think there is bug in the algorithm which could result in partial MMR authentication paths becoming invalid on update.
190705a
to
09850d4
Compare
applied requested changes, fixed the bug
09850d4
to
8b6462a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left just one small nit inline.
Before merging, could you check if it will break anything in the vm/base (I think VM should be fine, but base my need a small update).
Also, we should coordinate the update with @igamigo not to break the client for too long.
8b6462a
to
34eb6b4
Compare
|
Describe your changes
Adds a method
add
to thePartialMmr
.fixes: #258
Checklist before requesting a review
next
according to naming convention.