Remove ExactSizeIterator constraint from SimpleSmt::with_leaves()
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Nov 28, 2023
src/merkle/simple_smt/mod.rs
Outdated
| } | ||
| // compute the max number of entries. We use an upper bound of depth 63 because we consider | ||
| // passing in a vector of size 2^64 infeasible. | ||
| let max_num_entries = 2usize.pow(tree.depth.min(63).into()); |
There was a problem hiding this comment.
minor nit: we usually write 2_usize instead of 2usize.
|
Kudos, SonarCloud Quality Gate passed!
|
bobbinth
pushed a commit
that referenced
this pull request
Dec 21, 2023
…#228) * Change InvalidNumEntries error * max computation * remove length check * remove ExactSizeIterator constraint * fix InvalidNumEntries error condition * 2_usize
bobbinth
pushed a commit
that referenced
this pull request
Feb 14, 2024
…#228) * Change InvalidNumEntries error * max computation * remove length check * remove ExactSizeIterator constraint * fix InvalidNumEntries error condition * 2_usize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ExactSizeIteratorconstraint forces the caller to instantiate iterators into, say, aVec, which leads to useless memory allocations. The signature of the function is now cleaner as well.The one downside of this approach is that in the unlikely case that the collection indeed has more than 2^63 elements, then we will do a lot of processing before figuring that out. However, this will almost never happen, and we should optimize for the case where the iterator doesn't have too many elements.