Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the Miden VM (with updated miden-package crate) #376

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

greenhat
Copy link
Contributor

@greenhat greenhat commented Jan 22, 2025

This PR updates the Miden VM to https://github.com/0xPolygonMiden/miden-vm/tree/greenhat/miden-package-pre-eam-vm-for-compiler (the tip of the 0xPolygonMiden/miden-vm#1544 before rebasing on EAM version) and can be merged now.

@bobbinth
Copy link
Contributor

I'm planning to merge 0xPolygonMiden/miden-vm#1631 relatively soon (which will probably have impact on this PR).

@greenhat
Copy link
Contributor Author

I'm planning to merge 0xPolygonMiden/miden-vm#1631 relatively soon (which will probably have impact on this PR).

Thanks for the heads-up! As long as we can pin to a commit with my PR changes before the #1631 merge, we should be fine.

I'd prefer to migrate to the memory-addressable VM version after we got the frontend migrated and the new IR pipeline ironed out. I made #374 for this.

@greenhat
Copy link
Contributor Author

Alternatively, we can leave this PR as is and come back to it later, when we do the migration to element-addressable VM version. The main reason for this PR was to test updated miden-package and I already did it.

@greenhat greenhat force-pushed the greenhat/update-vm-package-2 branch from df873bc to ba202d7 Compare February 11, 2025 15:30
@greenhat
Copy link
Contributor Author

@bitwalker I rebased this branch and updated the VM to the version of my branch before it was rebased onto the EAM VM version (see link in the PR descrioption).

@greenhat greenhat marked this pull request as ready for review February 11, 2025 15:35
@greenhat greenhat requested a review from bitwalker February 11, 2025 15:36
@greenhat
Copy link
Contributor Author

@bitwalker With 0xPolygonMiden/miden-vm#1544 rebased the VM commit on which the next branch relies is gone. We need to merge this PR ASAP to keep the next branch green.

@bitwalker bitwalker merged commit c685473 into next Feb 13, 2025
5 checks passed
@bitwalker bitwalker deleted the greenhat/update-vm-package-2 branch February 13, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants