Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Linters #97

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Add Linters #97

merged 6 commits into from
Jul 11, 2024

Conversation

rachit77
Copy link
Contributor

Jira Ticket here

@rachit77 rachit77 requested a review from Stefan-Ethernal June 24, 2024 14:15
@rachit77 rachit77 marked this pull request as ready for review June 25, 2024 11:07
@rachit77 rachit77 requested a review from a team as a code owner June 25, 2024 11:07
@rachit77 rachit77 self-assigned this Jun 25, 2024
vcastellm
vcastellm approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
55.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@goran-ethernal goran-ethernal merged commit 2319d3c into main Jul 11, 2024
7 of 9 checks passed
@goran-ethernal goran-ethernal deleted the feat/CDK-313 branch July 11, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@rachit77 rachit77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rachit77 @vcastellm @Stefan-Ethernal @goran-ethernal