Make DAC ws config tracking optional #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begmaroman
requested review from
christophercampbell,
rachit77 and
arnaubennassar
|
christophercampbell
pushed a commit
that referenced
this pull request
Apr 17, 2024
christophercampbell
added a commit
that referenced
this pull request
Apr 17, 2024
Make DAC ws config tracking optional (#64)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the trackers that track url and addr config changes optional. Retain the initial lookup of the values, but optionally turn off the websocket event tracking.
This can help the gelato situation where they have flakey ws support, and don’t need the feature for now anyway.