Fix ContainsKey / ContainsValue confusion

0x0ade · Jul 24, 2024 · 27ac4d7 · 27ac4d7
1 parent 395470b
commit 27ac4d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CelesteNet.Server.FrontendModule/WSCMDs/WSCMDsExtra.cs b/CelesteNet.Server.FrontendModule/WSCMDs/WSCMDsExtra.cs
@@ -60,7 +60,7 @@ public class WSCMDBanExt : WSCMD {
                 if (plusCon == null)
                     continue;
 
-                if (!(plusCon.GetAssociatedData<ExtendedHandshake.ConnectionData>() is ExtendedHandshake.ConnectionData plConData && plConData.CheckEntries.ContainsKey(checkValueVal)))
+                if (!(plusCon.GetAssociatedData<ExtendedHandshake.ConnectionData>() is ExtendedHandshake.ConnectionData plConData && plConData.CheckEntries.ContainsValue(checkValueVal)))
                     continue;
 
                 if (ban.Name.IsNullOrEmpty())

diff --git a/CelesteNet.Server/ConPlus/ExtendedHandshake.cs b/CelesteNet.Server/ConPlus/ExtendedHandshake.cs
@@ -10,11 +10,11 @@ public class ExtendedHandshake : IConnectionFeature {
 
         public record ConnectionData(string CheckEnv = "", string CheckMAC = "", string CheckDevice = "", string SelfReportBan = "")  {
 
-            public IDictionary<string, string> CheckEntries => new Dictionary<string, string>() {
+            public Dictionary<string, string> CheckEntries => new Dictionary<string, string>() {
                 ["CheckEnv"] = CheckEnv,
                 ["CheckMAC"] = CheckMAC,
                 ["CheckDevice"] = CheckDevice,
-            }.AsReadOnly();
+            };
 
             public bool CheckEntriesValid => CheckEntries.All(e => !e.Value.IsNullOrEmpty());